Repository navigation
438 feature load sysml graphical bnfkgbnf into the code generator - #443
Merged
antoineatsoprasteria merged 2 commits intoNov 13, 2026
Conversation
…cationVisitor for SysML-graphical-bnf.kgbnf
4 of 5 tasks
|
joao4all
approved these changes
Nov 13, 2026
| } | ||
|
|
||
| /// <summary> | ||
| /// Returns the corrections that matched nothing during this generator run. |
There was a problem hiding this comment.
I see this is a public static class holding a private static AppliedRuleNames collection. Is this intended to be used elsewhere or just by the generator (one-run)? Just commenting this to double check the intent of the implementation, not an issue itself
Collaborator
Author
There was a problem hiding this comment.
Everything there is really in the scope of code-generation and won't ever be used in another scope
samatstariongroup
approved these changes
Nov 13, 2026
antoineatsoprasteria
deleted the
438-feature-load-sysml-graphical-bnfkgbnf-into-the-code-generator
branch
November 13, 2026 12:39
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.


Prerequisites
Description
Fix #438