Skip to content

438 feature load sysml graphical bnfkgbnf into the code generator - #443

Merged
antoineatsoprasteria merged 2 commits into
developmentfrom
438-feature-load-sysml-graphical-bnfkgbnf-into-the-code-generator
Nov 13, 2026
Merged

antoineatsoprasteria merged 2 commits into
developmentfrom
438-feature-load-sysml-graphical-bnfkgbnf-into-the-code-generator

Conversation

@antoineatsoprasteria

Copy link
Copy Markdown
Collaborator

Prerequisites

  • I have written a descriptive pull-request title
  • I have verified that there are no overlapping pull-requests open
  • I have verified that I am following the SysML2.NET code style guidelines
  • I have provided test coverage for my change (where applicable)

Description

Fix #438

  • G4 file created to allow ANTLR tokenizer
  • Ability to load KGBNF files and have access to all defined rules

@sonarqubecloud

Copy link
Copy Markdown

Quality Gate Failed Quality Gate failed

Failed conditions
68.5% Coverage on New Code (required ≥ 80%)

See analysis details on SonarQube Cloud

@joao4all joao4all left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

}

/// <summary>
/// Returns the corrections that matched nothing during this generator run.

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I see this is a public static class holding a private static AppliedRuleNames collection. Is this intended to be used elsewhere or just by the generator (one-run)? Just commenting this to double check the intent of the implementation, not an issue itself

Copy link
Copy Markdown
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Everything there is really in the scope of code-generation and won't ever be used in another scope

@antoineatsoprasteria
antoineatsoprasteria merged commit 149c68e into development Nov 13, 2026
7 of 8 checks passed
@antoineatsoprasteria
antoineatsoprasteria deleted the 438-feature-load-sysml-graphical-bnfkgbnf-into-the-code-generator branch November 13, 2026 12:39
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

[Feature]: Load SysML-graphical-bnf.kgbnf into the code generator

3 participants